LED intensity

OP (Company: None) #3957650 
Hello, I got an assignment to make LED lights change intensity, by 
switching 4 switches on pegasus board. I got some code but I don't think 
it's good. Can you check it or improve it? Thanks



1
library ieee;

2
use ieee.std_logic_1164.all;

3
use ieee.numeric_std.all;

4
 

5
entity PWM is

6
  generic

7
  (

8
    sd        : unsigned(11 downto 0) := X"C35" -- 3125 in hex

9
  );

10
  port

11
  (

12
    clock     : in   std_logic;

13
    switches  : in   unsigned(3 downto 0);

14
    pwm       : out  std_logic

15
  );

16
end PWM;

17
 

18
architecture behave_PWM of PWM is

19
  signal counter : unsigned(15 downto 0);

20
 

21
begin -- architecture

22
  pwm_proc: process (clock)

23
  begin

24
    if (counter <= switches*sd) then

25
      pwm <= '1';

26
    else

27
      pwm <= '0';

28
    end if;

29
 

30
    if (counter >= 50000) then

31
      counter <= (others => '0');

32
    else

33
      counter <= counter + 1;

34
    end if;

35
  end process;

36
 

37
end behave_PWM;
Reply Quote Edit Move Thread sperren Slow mode Anmeldepflicht aktivieren Anpinnen Delete topic Thread mit anderem zusammenführen Report Thanks
Moderator (Company: Titel) 
Oer Pdw wrote:
> I got some code but I don't think it's good.
You are right. This will work in a simulator at best. But you will never 
ever get it on hardware.

The major drawback is the missing clock inside the process. It is not 
enough to have the clock in the sensitivity list. Look how all the 
others do it...
Reply Quote Edit Delete Report Thanks
Moderator (Company: Titel) 
Oer Pdw wrote:
> The problem is that everyone has different task
What should this sentence say?

What I said is: there is no clock in your design! But each counter needs 
a clock because its built of flipflops. Have a look how everybody on the 
world describes a counter. There must be a rising_edge() or a 'event 
in your code!
Reply Quote Edit Delete Report Thanks
OP (Company: None) 
Is it good now?



1
library ieee;

2
use ieee.std_logic_1164.all;

3
use ieee.numeric_std.all;

4
 

5
entity PWM is

6
  generic

7
  (

8
    sd        : unsigned(7 downto 0) := X"C3" -- 195 in hex

9
  );

10
  port

11
  (

12
    clock     : in   std_logic;

13
    switches  : in   unsigned(7 downto 0);

14
    pwm       : out  std_logic

15
  );

16
end PWM;

17
 

18
architecture behave_PWM of PWM is

19
  signal counter : unsigned(15 downto 0);

20
 

21
begin -- architecture

22
  pwm_proc: process (clock)

23
  begin

24
if(clock'event and clock='0'") then

25
    if (counter <= switches*sd) then

26
      pwm <= '1';

27
    else

28
      pwm <= '0';

29
    end if;

30
 

31
    if (counter >= 50000) then

32
      counter <= (others => '0');

33
    else

34
      counter <= counter + 1;

35
end if;

36
    end if;

37
  end process;

38
 

39
end behave_PWM;
Reply Quote Edit Delete Report Thanks
Watch this topic

Reply

A question of your own? This thread is over 11 years old. Ask it in a thread of its own – more people read along there, and it gets answered more often and sooner.

Start a new thread

A fix, an addition or feedback on this thread? Then reply here.

Formatting
  • [c]C-Code[/c]
  • [vhdl]VHDL-Code[/vhdl]
  • [code]code in other languages, ASCII drawings[/code]
  • [math]formula (LaTeX syntax)[/math]
  • [[Title]] – link to an article
  • Link to another post: right-click its post ID (#8078628), copy the address, paste it into the text

More about formatting

Post long source code as an attachment, not in the text.

Your name and e-mail address

Already registered? Log in

Not shown to anyone. We send you a link; your post appears once you confirm it there.

By submitting you create a free account and accept the terms of use.